[PATCH] D137028: [llvm][utils] Add DenseMap data formatters (WIP)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I really like that this doesn't run expressions!



================
Comment at: llvm/utils/lldbDataFormatters.py:328
+
+        # Get the std::pair from the DenseMapPair
+        if entry.type.name.startswith("llvm::detail::DenseMapPair<"):
----------------
.


================
Comment at: llvm/utils/lldbDataFormatters.py:330
+        if entry.type.name.startswith("llvm::detail::DenseMapPair<"):
+            entry = entry.GetChildAtIndex(0)
+
----------------
else error?


================
Comment at: llvm/utils/lldbDataFormatters.py:347
+
+        # Bucket entries contain are one of the following:
+        #   1. Valid key-value
----------------
typo


================
Comment at: llvm/utils/lldbDataFormatters.py:362
+
+        # Hueristic: Repated (non-unique) keys are either the the empty key or
+        # the tombstone key. Populate child_buckets with the bucket indexes of
----------------
heuristic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137028/new/

https://reviews.llvm.org/D137028