[PATCH] D134711: [AArch64] Select SMULL for zero extended vectors when top bit is zero

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 02:06:53 PST 2022


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4381
 static unsigned selectUmullSmull(SDNode *&N0, SDNode *&N1, SelectionDAG &DAG,
-                                 bool &IsMLA) {
+                                 SDLoc DL, bool &IsMLA) {
   bool IsN0SExt = isSignExtended(N0, DAG);
----------------
Is there some other changes needed here, to pass a DL through to the function from the callsites of selectUmullSmull?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134711/new/

https://reviews.llvm.org/D134711



More information about the llvm-commits mailing list