[PATCH] D137651: [LoopFlatten] Forget SCEV block and loop dispositions for removed incomming values of phi

[luxufan via Phabricator via llvm-commits]

StephenFan added a comment.

In D137651#3915377 <https://reviews.llvm.org/D137651#3915377>, @nikic wrote:

> Are you sure we need to forget the incoming value rather than the phi? I haven't looked at the code in detail, but I'd generally expect that removing an incoming value doesn't change dispositions of that value, but may change dispositions of the using phi.

If I understand correctly, the phi will be forgotten when calling forgetLoop method in the below.  But I found that just forgetting the incoming value is still not sufficient or is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137651/new/

https://reviews.llvm.org/D137651