[PATCH] D137651: [LoopFlatten] Forget SCEV block and loop dispositions for removed incomming values of phi
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 09:38:17 PST 2022
nikic added a comment.
Are you sure we need to forget the incoming value rather than the phi? I haven't looked at the code in detail, but I'd generally expect that removing an incoming value doesn't change dispositions of that value, but may change dispositions of the using phi.
================
Comment at: llvm/test/Transforms/LoopFlatten/pr58865.ll:1
+; RUN: opt -loop-flatten -verify-scev < %s
+
----------------
I'd suggest adding check lines as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137651/new/
https://reviews.llvm.org/D137651
More information about the llvm-commits
mailing list