[PATCH] D137431: [AArch64] RME MEC instructions and system registers

Keith Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 07:34:31 PST 2022


keith.walker.arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3490
     {"mops", {AArch64::FeatureMOPS}},
+    {"mec", {AArch64::FeatureMEC}},
     // FIXME: Unsupported extensions
----------------
lenary wrote:
> This should not be included. These names are supposed to be the same as command-line extension options, which MEC doesn't have.
> 
> At the very least, it's also untested, but I think it should be removed, not tested.
So I assume we want uses of MEC to be gated on the use of AArch64::FeatureRME instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137431/new/

https://reviews.llvm.org/D137431



More information about the llvm-commits mailing list