[PATCH] D137431: [AArch64] RME MEC instructions and system registers
Sam Elliott via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 03:59:32 PST 2022
lenary added a comment.
Sorry, a quick drive-by comment. I'll try to get back to this to do a fuller review on Wednesday.
================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3490
{"mops", {AArch64::FeatureMOPS}},
+ {"mec", {AArch64::FeatureMEC}},
// FIXME: Unsupported extensions
----------------
This should not be included. These names are supposed to be the same as command-line extension options, which MEC doesn't have.
At the very least, it's also untested, but I think it should be removed, not tested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137431/new/
https://reviews.llvm.org/D137431
More information about the llvm-commits
mailing list