[PATCH] D137574: PEI should be able to use backward walk in replaceFrameIndicesBackward.

[Alexander via Phabricator via llvm-commits]

alex-t added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1440
           .addImm(Offset);
-      Add->getOperand(3).setIsDead(); // Mark SCC as dead.
     }
----------------
arsenm wrote:
> It's still dead. Even if we wanted to remove this, it doesn't belong in this patch 
> It's still dead. Even if we wanted to remove this, it doesn't belong in this patch 




================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1440
           .addImm(Offset);
-      Add->getOperand(3).setIsDead(); // Mark SCC as dead.
     }
----------------
alex-t wrote:
> arsenm wrote:
> > It's still dead. Even if we wanted to remove this, it doesn't belong in this patch 
> > It's still dead. Even if we wanted to remove this, it doesn't belong in this patch 
> 
> 
Yeah, I know. I will remove it. This is not a final change - it is just a draft.
I opened it to be able to discuss the design and solutions with all of you.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137574/new/

https://reviews.llvm.org/D137574