[PATCH] D137574: PEI should be able to use backward walk in replaceFrameIndicesBackward.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1360
 
+bool PEI::replaceFrameIndexDebugInstr(MachineFunction &MF, MachineInstr &MI,
+                                      unsigned OpIdx, int SPAdj) {
----------------
Can you factor out the debug instruction handling refactor in a pre-commit


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1440
           .addImm(Offset);
-      Add->getOperand(3).setIsDead(); // Mark SCC as dead.
     }
----------------
It's still dead. Even if we wanted to remove this, it doesn't belong in this patch 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137574/new/

https://reviews.llvm.org/D137574