[PATCH] D137341: [VectorCombine] widen a load with subvector insert

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D137341#3912838 <https://reviews.llvm.org/D137341#3912838>, @spatel wrote:

> Rebased with a new test (last test/diff in the test file) that includes addrspacecast. This will crash if we don't re-insert a cast.
>
> I think we could reduce the wordiness by calling `CreatePointerCast()` rather than `CreateBitCastOrAddrSpaceCast()`, but I'd make that change to the existing code too to keep these in sync (assuming that works in the other transform).

CreateBitCast should be adequate. If you need to, there's stripPointerCastsSameRepresentation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137341/new/

https://reviews.llvm.org/D137341