[PATCH] D137341: [VectorCombine] widen a load with subvector insert

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 09:57:25 PST 2022


spatel updated this revision to Diff 473724.
spatel added a comment.

Rebased with a new test (last test/diff in the test file) that includes addrspacecast. This will crash if we don't re-insert a cast.

I think we could reduce the wordiness by calling `CreatePointerCast()` rather than `CreateBitCastOrAddrSpaceCast()`, but I'd make that change to the existing code too to keep these in sync (assuming that works in the other transform).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137341/new/

https://reviews.llvm.org/D137341

Files:
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/VectorCombine/X86/load-widening.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137341.473724.patch
Type: text/x-patch
Size: 11087 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/04caa2a7/attachment.bin>


More information about the llvm-commits mailing list