[PATCH] D136173: [DebugInfo] Add function to test debug values for equivalence

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:678
 
+bool MachineInstr::isEquivalentDbgInstr(const MachineInstr &Other) const {
+  if (!isDebugValue() || !Other.isDebugValue())
----------------
Should this function also check that the `DILocalVariable` field matches?


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1383-1385
+  // If Expr is indirect, insert the implied DW_OP_deref at the end of the
+  // expression but before DW_OP_{stack_value, LLVM_fragment} if they are
+  // present.
----------------
Have you seen (/got an example of) an indirect debug intrinsic using `stack_value` "naturally" in IR? I feel like that's something that shouldn't exist, but maybe I'm missing something / not being creative enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136173/new/

https://reviews.llvm.org/D136173