[PATCH] D136173: [DebugInfo] Add function to test debug values for equivalence

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 05:48:43 PST 2022


StephenTozer updated this revision to Diff 473636.
StephenTozer added a comment.

Address review comments, including removing the unnecessary call to `MachineInstr::isIdenticalTo` in `MachineInstr::isEquivalentDbgInstr` and also adding a missing check for `getDebugLoc` equality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136173/new/

https://reviews.llvm.org/D136173

Files:
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
  llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/Generic/merge-equivalent-ranges.ll
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136173.473636.patch
Type: text/x-patch
Size: 17432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/cbc9d953/attachment.bin>


More information about the llvm-commits mailing list