[PATCH] D136915: Add build for Windows on Arm in packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:330
+
+mkdir libxmlbuild
+cd libxmlbuild
----------------
omjavaid wrote:
> We are doing libxmlbuild above for x64 as well. This is duplicating the same code.
I agree, but I'd prefer to factor all this in another patch if that's fine for you.
(build32 and build64 are already duplicated).

The goal is to upstream faster arm64 build (instead of doing a refactor patch before), and then do a cleanup where people can argue :)


================
Comment at: llvm/utils/release/build_llvm_release.bat:417
+
+rename LLVM-%package_version%-win64.exe LLVM-%package_version%-woa64.exe || exit /b 1
+7z x LLVM-%package_version%-woa64.exe -orepack || exit /b 1
----------------
omjavaid wrote:
> cant we produce woa64 package that we dont have to rename it here.
Good point!
It should be enough to configure CPACK_SYSTEM_NAME to woa64 for obtaining this result. I'll give it a try.
https://cmake.org/cmake/help/latest/module/CPack.html#variable:CPACK_PACKAGE_FILE_NAME


================
Comment at: llvm/utils/release/build_llvm_release.bat:421
+del repack\Uninstall.exe || exit /b 1
+7z a LLVM-%package_version%-woa64.zip .\repack\* -mx9 || exit /b 1
+cd ..
----------------
omjavaid wrote:
> zip file seems redundant.
 I can remove this step (just did the same than original tcwg script).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136915/new/

https://reviews.llvm.org/D136915