[PATCH] D136915: Add build for Windows on Arm in packaging script

Muhammad Omair Javaid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 02:49:53 PDT 2022


omjavaid added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:330
+
+mkdir libxmlbuild
+cd libxmlbuild
----------------
pbo-linaro wrote:
> omjavaid wrote:
> > We are doing libxmlbuild above for x64 as well. This is duplicating the same code.
> I agree, but I'd prefer to factor all this in another patch if that's fine for you.
> (build32 and build64 are already duplicated).
> 
> The goal is to upstream faster arm64 build (instead of doing a refactor patch before), and then do a cleanup where people can argue :)
We already have a working copy of this script in Linaro toolchain repositories. There is no urgency to have the same build script available in LLVM upstream mono repo. We still have 8 - 12 weeks until next LLVM release is due so we should target for a cleaned up script with minimum or no duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136915/new/

https://reviews.llvm.org/D136915



More information about the llvm-commits mailing list