[PATCH] D136915: Add build for Windows on Arm in packaging script

[Muhammad Omair Javaid via Phabricator via llvm-commits]

omjavaid added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:313
+::==============================================================================
+:: Build arm64 binaries.
+::==============================================================================
----------------
 There seems to a  lot of similarities overall can we combine build64 and do_build_arm64.


================
Comment at: llvm/utils/release/build_llvm_release.bat:330
+
+mkdir libxmlbuild
+cd libxmlbuild
----------------
We are doing libxmlbuild above for x64 as well. This is duplicating the same code.


================
Comment at: llvm/utils/release/build_llvm_release.bat:417
+
+rename LLVM-%package_version%-win64.exe LLVM-%package_version%-woa64.exe || exit /b 1
+7z x LLVM-%package_version%-woa64.exe -orepack || exit /b 1
----------------
cant we produce woa64 package that we dont have to rename it here.


================
Comment at: llvm/utils/release/build_llvm_release.bat:421
+del repack\Uninstall.exe || exit /b 1
+7z a LLVM-%package_version%-woa64.zip .\repack\* -mx9 || exit /b 1
+cd ..
----------------
zip file seems redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136915/new/

https://reviews.llvm.org/D136915