[PATCH] D123968: docs: Add instructions for stand-alone builds of clang

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: llvm/docs/GettingStarted.rst:139
+============ ======================== ======================
+clang        clang, cmake             CLANG_INCLUDE_TESTS=ON (Required for check-clang only)
+============ ======================== ======================
----------------
tstellar wrote:
> tstellar wrote:
> > mgorny wrote:
> > > h-vetinari wrote:
> > > > Isn't CLANG_BUILT_STANDALONE also necessary (honest question)?
> > > In Gentoo, we also check `llvm/lib/Transforms/Hello` out unconditionally (don't recall why we added it, maybe it's not needed anymore, gotta check at some point), and `llvm/lib/Testing/Support` and `llvm/utils` for tests.
> > Transforms/Hello is only needed if you build clang-tools-extra (which is not enabled with these instructions).  I also have a patch to make the D120301.
> > 
> > Testing/Support is only needed for the unittests which aren't run in the documented configuration (because there is no googletest).
> > 
> > I don't think llvm/utils is needed after https://github.com/llvm/llvm-project/commit/74384c7fcec71cb040b0c874743e5fc38b2cd7a6
> > 
> > This documentation is for the most minimal config that I could get working without any additional changes, so no clang-tools-extra and no unittests.
> > Isn't CLANG_BUILT_STANDALONE also necessary (honest question)?
> 
> No, this value is auto-detected based on the source layout.
> 
> 
> Testing/Support is only needed for the unittests which aren't run in the documented configuration (because there is no googletest).

Well, I don't want to hijack your effort but I think unittests are quite important if we're running tests in the first place, and I don't recall needing anything "that special" to run them these days — just `llvm/lib/Testing/Support` and `llvm/utils/{lit,llvm-lit,unittest}` (however, given its size I suppose we could just take whole `llvm/utils`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123968/new/

https://reviews.llvm.org/D123968