[PATCH] D123968: docs: Add instructions for stand-alone builds of clang

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: llvm/docs/GettingStarted.rst:110
 
+Stand-alone Builds
+------------------
----------------
MaskRay wrote:
> I just read https://brians.wsu.edu/2016/05/31/standalone-stand-alone/
> 
> When one greps in `llvm-project`, which word do they more likely use, `standalone` or `stand-alone`? I tend to use `standalone`. Then I checked `git shortlog -sn --grep standalone` and `git shortlog -sn --grep stand-alone`. The former is more popular while the latter is not too uncommon...
I agree we should be consistent, but I have not preference about which spelling to use.


================
Comment at: llvm/docs/GettingStarted.rst:134
+
+  ninja -C $builddir install
+
----------------
MaskRay wrote:
> Does `install-distribution` with `LLVM_DISTRIBUTION_COMPONENTS` work? From the name, `LLVM_DISTRIBUTION_COMPONENTS`  is recommended for distributions and standalone builds are preferred by distributions.
For Fedora, we don't use LLVM_DISTRIBUTION_COMPONENT, mainly because we already install everything, but also because it's very hard to keep the variable updated when new things are added.  My concern with using it is that we would easily miss new features.


================
Comment at: llvm/docs/GettingStarted.rst:146
+if llvm is installed into ``/usr/bin`` and ``/usr/lib64``, then you should pass
+``-DLLVM_ROOT=/usr/``.  Both the LLVM_ROOT and LLVM_EXTERNAL_LIT options
+are required to do stand-alone builds for all sub-projects.  Additional required
----------------
MaskRay wrote:
> Is the formal CMake term "variable" instead of "option"?
Technically, those are both variables internally, but the cmake man page refers to anything passed to cmake command line as an option.


================
Comment at: llvm/docs/GettingStarted.rst:157
+llvm         llvm, cmake, third-party LLVM_INSTALL_UTILS=ON
+clang        clang, cmake             CLANG_INCLUDE_TESTS=ON (Required for check-clang only)
+============ ======================== ======================
----------------
MaskRay wrote:
> You may check what `flang` requires and make the second column sufficiently long to accommodate its needs.
This is going to take a lot of work to figure out, maybe I can just make the column 20 chars longer?  I think ideally flang would require just cmake, but I don't have any experience trying to do a stand-alone build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123968/new/

https://reviews.llvm.org/D123968