[llvm] 8d7f884 - Revert "[AMDGPU] Add EXPENSIVE_CHECK into GCNRPTracker::reset"

[Valery Pykhtin via llvm-commits]

Author: Valery Pykhtin
Date: 2022-10-28T09:15:37+02:00
New Revision: 8d7f88416a12a970eebe58c81329e1ac05280345

URL: https://github.com/llvm/llvm-project/commit/8d7f88416a12a970eebe58c81329e1ac05280345
DIFF: https://github.com/llvm/llvm-project/commit/8d7f88416a12a970eebe58c81329e1ac05280345.diff

LOG: Revert "[AMDGPU] Add EXPENSIVE_CHECK into GCNRPTracker::reset"

This reverts commit fecf067db40ffa1a6d5d665769c90cd29547f502.

The change introduces 420 test failures with EXPENSIVE_CHECK in AMDGPU which I don't want to disable.
Going to fix the failures and recommit the check.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/GCNRegPressure.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/GCNRegPressure.cpp b/llvm/lib/Target/AMDGPU/GCNRegPressure.cpp
index e0059e6b51cf..2f38f7f65f80 100644
--- a/llvm/lib/Target/AMDGPU/GCNRegPressure.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNRegPressure.cpp
@@ -260,22 +260,6 @@ void GCNRPTracker::reset(const MachineInstr &MI,
   }
 
   MaxPressure = CurPressure = getRegPressure(*MRI, LiveRegs);
-
-  LLVM_DEBUG(dbgs() << "\nReset " << (After ? "after" : "before") << ": " << MI
-                    << print(LiveRegs, *MRI));
-#if defined(EXPENSIVE_CHECKS) && !defined(NDEBUG)
-  if (LiveRegsCopy) {
-    auto LISLRS =
-        After ? getLiveRegsAfter(MI, LIS) : getLiveRegsBefore(MI, LIS);
-    if (!isEqual(LISLRS, *LiveRegsCopy)) {
-      dbgs() << "RP mismatch: "
-             << reportMismatch(LISLRS, *LiveRegsCopy,
-                               MRI->getTargetRegisterInfo());
-      llvm_unreachable("GCNRPTracker::reset LiveRegsCopy doens't match those "
-                       "calculated by LIS");
-    }
-  }
-#endif
 }
 
 void GCNUpwardRPTracker::reset(const MachineInstr &MI,