[PATCH] D136861: [IR] Add LLVM IR support for aarch64_svcount opaque type.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 02:13:10 PDT 2022


nikic added a comment.

In D136861#3890025 <https://reviews.llvm.org/D136861#3890025>, @aemerson wrote:

> Ah ok, that's fine then. Although from looking at D135202 <https://reviews.llvm.org/D135202> it doesn't look like the design has been settled yet? I don't think we should be writing patches upon speculative changes, so unless D135202 <https://reviews.llvm.org/D135202> is going to land very soon I'd prefer we continued with the traditional approach.

Yeah, possibly. I'd suggest to still consider the possibility when you put up the RFC for this change, as it's likely going to be an easier sell if it doesn't require the addition of a new target-specific type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136861/new/

https://reviews.llvm.org/D136861



More information about the llvm-commits mailing list