[PATCH] D136861: [IR] Add LLVM IR support for aarch64_svcount opaque type.

Joshua Cranmer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 14:23:24 PDT 2022


jcranmer-intel added a comment.

In D136861#3890025 <https://reviews.llvm.org/D136861#3890025>, @aemerson wrote:

> Ah ok, that's fine then. Although from looking at D135202 <https://reviews.llvm.org/D135202> it doesn't look like the design has been settled yet? I don't think we should be writing patches upon speculative changes, so unless D135202 <https://reviews.llvm.org/D135202> is going to land very soon I'd prefer we continued with the traditional approach.

At a quick glance of this patch, this does seem like something that could be built on top of opaque types were they already landed, so it's at least worth considering how this type might be implemented as an opaque type. The thing that's the most unsettled in the design is effectively the communication of `DataLayout`-like type properties of target types, and while I hoped to have a solution to that coded up today, I didn't get enough time to do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136861/new/

https://reviews.llvm.org/D136861



More information about the llvm-commits mailing list