[PATCH] D136861: [IR] Add LLVM IR support for aarch64_svcount opaque type.

Thu Oct 27 15:09:29 PDT 2022

aemerson added a comment.

In D136861#3889901 <https://reviews.llvm.org/D136861#3889901>, @nikic wrote:

> In D136861#3889897 <https://reviews.llvm.org/D136861#3889897>, @aemerson wrote:
>
>> In D136861#3889474 <https://reviews.llvm.org/D136861#3889474>, @nikic wrote:
>>
>>> Any chance this can be implemented as an opaque type as introduced in https://reviews.llvm.org/D135202 instead? Providing a general mechanism for target-specific types is the purpose of opaque types, so it would be great if they work for this use case. cc @jcranmer-intel
>>
>> Can this be implemented in the existing way? Otherwise users of -DCLANG_ENABLE_OPAQUE_POINTERS=OFF/-Xclang -no-opaque-pointers won't be able to use SME intrinsics.
>
> Despite both having "opaque" in the name, opaque pointers and opaque types aren't really related. Opaque types would work even with `-no-opaque-pointers`.

Ah ok, that's fine then. Although from looking at D135202 <https://reviews.llvm.org/D135202> it doesn't look like the design has been settled yet? I don't think we should be writing patches upon speculative changes, so unless D135202 <https://reviews.llvm.org/D135202> is going to land very soon I'd prefer we continued with the traditional approach.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136861/new/

https://reviews.llvm.org/D136861