[PATCH] D136452: [bazel] Add missing C++ style clang headers

Aaron Siddhartha Mondal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 15:32:00 PDT 2022


aaronmondal added a comment.

@chapuni I think fully expanding the glob does not really gain us anything. It would only add ~300 lines of headers, which I would assume to not really impact builds anyways, except if a header is missing as in `openmp_headers/time.h`. Keeping those up to date would likely be unnecessary maintenance burden.

I'll revert to Diff2 and add the `module.modulemap` as well, which is also part of the core files exported by the CMake build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136452/new/

https://reviews.llvm.org/D136452



More information about the llvm-commits mailing list