[PATCH] D136452: [bazel] Add missing C++ style clang headers

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

Excuse me, I forgot trailer asterisks in my previous comment.

> Regarding the updated diff, it will work, but may go slightly against the guideline in https://bazel.build/reference/be/functions#glob, stating
>
>> In general, you should try to provide an appropriate extension (e.g. *.html) instead of using a bare '*' for a glob pattern. The more explicit name is both self documenting and ensures that you don't accidentally match backup files, or emacs/vi/... auto-save files.
>
> I don't think this is an issue in this particular case though.

I have rethought it should be an issue. We should not use glob for C++ suffix-less headers.
Your Diff 2 would be sufficient for now, I think.

Or shall we expand globbing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136452/new/

https://reviews.llvm.org/D136452