[PATCH] D136452: [bazel] Add missing C++ style clang headers

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1478
+        "lib/Headers/**/*.h",
+        "lib/Headers/cuda_wrappers/algorithm",
+        "lib/Headers/cuda_wrappers/complex",
----------------
chapuni wrote:
> Seems odd to pass non-wildcard files to `glob`.
> 
> Instead, could we reorganize the pattern? Like,
> 
> * `lib/Headers/*.h`
> * `lib/Headers/cuda_wrappers`
> * `lib/Headers/openmp_wrappers`
> * `lib/Headers/ppc_wrappers`
> 
> (`clang/lib/Headers/hlsl` may be excluded here for now, since HLSL is not enabled in bazel build)
There would also be the possibility to use (note the last line)
```
"lib/Headers/*.h",
"lib/Headers/cuda_wrappers/*",
"lib/Headers/openmp_wrappers/*",
"lib/Headers/ppc_wrappers/*.h",
```
but I think just using the asterisks in this case should be clear enough. Omitting the asterisks won't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136452/new/

https://reviews.llvm.org/D136452