[PATCH] D136632: [ObjectYAML] Add support for DXContainer HASH

[Xiang Li via Phabricator via llvm-commits]

python3kgae added inline comments.


================
Comment at: llvm/lib/BinaryFormat/DXContainer.cpp:28
+bool ShaderHash::isPopulated() {
+  static uint8_t Zeros[16] = {0};
+  return Flags > 0 || 0 != memcmp(&Digest, &Zeros, 16);
----------------
add const to Zeros?


================
Comment at: llvm/lib/BinaryFormat/DXContainer.cpp:29
+  static uint8_t Zeros[16] = {0};
+  return Flags > 0 || 0 != memcmp(&Digest, &Zeros, 16);
+}
----------------
Why do we want to set Digest to Zeros when Flags is 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136632/new/

https://reviews.llvm.org/D136632