[PATCH] D136632: [ObjectYAML] Add support for DXContainer HASH

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/BinaryFormat/DXContainer.cpp:29
+  static uint8_t Zeros[16] = {0};
+  return Flags > 0 || 0 != memcmp(&Digest, &Zeros, 16);
+}
----------------
python3kgae wrote:
> Why do we want to set Digest to Zeros when Flags is 0?
This doesn't set, it compares. If flags and the digest are all zero'd it wasn't populated, so we can omit it from the textual YAML output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136632/new/

https://reviews.llvm.org/D136632