[PATCH] D136632: [ObjectYAML] Add support for DXContainer HASH

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 12:39:12 PDT 2022


beanz added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/DXContainerYAML.h:70
+  bool IncludesSource;
+  std::vector<llvm::yaml::Hex8> Digest;
+};
----------------
python3kgae wrote:
> Why use vector here when the size is always 16?
We can't bind yaml traits to statically sized arrays because YAML doesn't have statically sized arrays.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136632/new/

https://reviews.llvm.org/D136632



More information about the llvm-commits mailing list