[PATCH] D136377: [mlir][MemRefToLLVM] Reuse existing subview lowering

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 09:52:34 PDT 2022


qcolombet added a comment.

> Ideally, there shouldn't be a dependency on the Affine dialect either, but I can live with that if it is minimal.

To comment on that, the alternative would be to produce `arith` ops instead of `affine.apply` in the lowering of `subview`, `expand_shape`, etc., but Nicolas and I thought the affine.apply was easier to reason about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136377/new/

https://reviews.llvm.org/D136377



More information about the llvm-commits mailing list