[PATCH] D136377: [mlir][MemRefToLLVM] Reuse existing subview lowering

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi @ftynse ,

Thanks for the review.

> I don't think `memref-to-llvm` should subsume `affine-to-llvm` and `arith-to-llvm`.

We had this exact same discussion with @nicolasvasilache  and thought it was fine.
The alternative I can see is we could declare `affine.apply` legal, so that they don't get expanded in the process. The problem with that is it is oddly specific.

Let me check if that would work to begin with.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136377/new/

https://reviews.llvm.org/D136377