[PATCH] D136377: [mlir][MemRefToLLVM] Reuse existing subview lowering

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 19:45:48 PDT 2022


qcolombet added a comment.

> The alternative I can see is we could declare affine.apply legal, so that they don't get expanded in the process.

To report on this, if I add `target.addLegalOp<AffineApplyOp>();` we can avoid adding the conversion from affine-to-llvm and arith-to-llvm. The downside is that memref-to-llvm may create `affine.apply` ops.

@ftynse what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136377/new/

https://reviews.llvm.org/D136377



More information about the llvm-commits mailing list