[PATCH] D135942: [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 12:29:04 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rG316123a2fce2: [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O (authored by int3).

Changed prior to commit:
  https://reviews.llvm.org/D135942?vs=467686&id=467887#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135942/new/

https://reviews.llvm.org/D135942

Files:
  lld/MachO/Symbols.cpp


Index: lld/MachO/Symbols.cpp
===================================================================
--- lld/MachO/Symbols.cpp
+++ lld/MachO/Symbols.cpp
@@ -9,7 +9,7 @@
 #include "Symbols.h"
 #include "InputFiles.h"
 #include "SyntheticSections.h"
-#include "lld/Common/Strings.h"
+#include "llvm/Demangle/Demangle.h"
 
 using namespace llvm;
 using namespace lld;
@@ -32,9 +32,9 @@
 static std::string maybeDemangleSymbol(StringRef symName) {
   if (config->demangle) {
     symName.consume_front("_");
-    return demangle(symName, true);
+    return demangle(symName.str());
   }
-  return std::string(symName);
+  return symName.str();
 }
 
 std::string lld::toString(const Symbol &sym) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135942.467887.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221014/f1f4c781/attachment.bin>


More information about the llvm-commits mailing list