[PATCH] D135943: [lld][nfc] Remove lld::demangle() (partial revert of D116279)

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added reviewers: MaskRay, thakis, ljmf00.
Herald added subscribers: pmatos, asb, StephenFan, sunfish, arichardson, sbc100, emaste.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
int3 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

D116279: [lld] Add support for other demanglers other than Itanium <https://reviews.llvm.org/D116279>, in addition to adding support for other demanglers, also
factored out some of the demangling logic. However, I don't think the
abstraction really carries its weight -- after D135942: [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O <https://reviews.llvm.org/D135942>, only the ELF
and WASM backends call it with anything other than a non-constant
`shouldDemangle` argument. The COFF and Mach-O backends were already
doing the should-demangle check before calling `demangle()`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135943

Files:
  lld/COFF/Symbols.cpp
  lld/ELF/SymbolTable.cpp
  lld/ELF/Symbols.cpp
  lld/MachO/SymbolTable.cpp
  lld/include/lld/Common/Strings.h
  lld/wasm/Symbols.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135943.467687.patch
Type: text/x-patch
Size: 4601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221014/f034b131/attachment.bin>