[PATCH] D135942: [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Symbols.cpp:35
     symName.consume_front("_");
-    return demangle(symName, true);
+    return demangle(std::string(symName));
   }
----------------
oontvoo wrote:
> nit: `demangle(symName.str().c_str());` ? (no need to make a new `std::string`?)
demangle takes an std::string, so this would construct two std::strings :)

I can change it to `.str()` though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135942/new/

https://reviews.llvm.org/D135942