[PATCH] D135942: [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 11:34:40 PDT 2022


oontvoo added inline comments.


================
Comment at: lld/MachO/Symbols.cpp:35
     symName.consume_front("_");
-    return demangle(symName, true);
+    return demangle(std::string(symName));
   }
----------------
nit: `demangle(symName.str().c_str());` ? (no need to make a new `std::string`?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135942/new/

https://reviews.llvm.org/D135942



More information about the llvm-commits mailing list