[PATCH] D135805: [AArch64] Fix potentially incorrect SEH stack allocs for realignments
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 12 12:49:40 PDT 2022
efriedma added a comment.
It's complete nonsense either way; we don't know how many bytes an "and" allocates.
But yes, this should be unreachable now; realignment implies a frame pointer, and a frame pointer implies we've already set NeedsWinCFI is false. (But even before a07787c9 <https://reviews.llvm.org/rGa07787c9a50c046e45921dd665f5a53a752bbc31>, the amount we allocate here doesn't matter; realignment implies a frame pointer, so the setfp is just going going to overwrite the stack pointer no matter what it contains.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135805/new/
https://reviews.llvm.org/D135805
More information about the llvm-commits
mailing list