[PATCH] D135805: [AArch64] Fix potentially incorrect SEH stack allocs for realignments

Wed Oct 12 13:30:40 PDT 2022

mstorsjo abandoned this revision.
mstorsjo added a comment.

In D135805#3853678 <https://reviews.llvm.org/D135805#3853678>, @efriedma wrote:

> (But even before a07787c9 <https://reviews.llvm.org/rGa07787c9a50c046e45921dd665f5a53a752bbc31>, the amount we allocate here doesn't matter; realignment implies a frame pointer, so the setfp is just going going to overwrite the stack pointer no matter what it contains.)

Doh, of course. Yeah, whatever nonsense value has been written here before hasn't really had any effect anyway.

Thus I guess it's better to abandon this and make a different patch that simply removes this case and potential other cases where we add SEH opcodes that never will be included any longer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135805/new/

https://reviews.llvm.org/D135805