[PATCH] D135538: [RISCV] Use hasAllWUsers to recover XORI/ORI

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 9 22:51:32 PDT 2022


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM if you add the blank line to the test as I noted previously.



================
Comment at: llvm/test/CodeGen/RISCV/rv64i-demanded-bits.ll:125
+; CHECK-NEXT:    subw a0, a0, a1
+; CHECK-NEXT:    addiw a0, a0, -8
+; CHECK-NEXT:    sw a0, 0(a2)
----------------
craig.topper wrote:
> liaolucy wrote:
> > looks good, no need to optimize.
> The ADDI being before the SUBW probably means this didn’t test what it was supposed to.
I attempted to make ADDI file but I haven't been able to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135538/new/

https://reviews.llvm.org/D135538



More information about the llvm-commits mailing list