[PATCH] D135538: [RISCV] Use hasAllWUsers to recover XORI/ORI

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rv64i-demanded-bits.ll:125
+; CHECK-NEXT:    subw a0, a0, a1
+; CHECK-NEXT:    addiw a0, a0, -8
+; CHECK-NEXT:    sw a0, 0(a2)
----------------
liaolucy wrote:
> looks good, no need to optimize.
The ADDI being before the SUBW probably means this didn’t test what it was supposed to.


================
Comment at: llvm/test/CodeGen/RISCV/rv64i-demanded-bits.ll:159
+}
 ; SimplifyDemandedBits breaks the ANDI by turning -8 into 0xfffffff8. This
 ; gets CSEd with the AND needed for type legalizing the lshr. This increases
----------------
Add blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135538/new/

https://reviews.llvm.org/D135538