[PATCH] D135302: [AArch64] Support SETCCCARRY lowering

Filipp Zhinkin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 00:28:55 PDT 2022


fzhinkin created this revision.
Herald added subscribers: armkevincheng, sjarus, eric-k256, hiraditya, kristof.beyls.
Herald added a project: All.
fzhinkin updated this revision to Diff 465524.
fzhinkin added a comment.
fzhinkin added reviewers: efriedma, samtebbs, dmgreen.
fzhinkin published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Updated tests



================
Comment at: llvm/test/CodeGen/AArch64/i128-cmp.ll:24
 ; CHECK-NEXT:    eor x9, x0, x2
 ; CHECK-NEXT:    orr x8, x9, x8
 ; CHECK-NEXT:    cmp x8, #0
----------------
Also checking if it's possible to use setcccarry to lower setcc eq/ne. It seems like it may improve code on x86, ARM and AArch64, but I'd prefer fixing it separately.


Support SETCCCARRY lowering to SBCS instruction.

Related issue: https://github.com/llvm/llvm-project/issues/44629


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135302

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/test/CodeGen/AArch64/arm64-atomic-128.ll
  llvm/test/CodeGen/AArch64/fpclamptosat.ll
  llvm/test/CodeGen/AArch64/fpclamptosat_vec.ll
  llvm/test/CodeGen/AArch64/i128-cmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135302.465524.patch
Type: text/x-patch
Size: 20853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221006/4c07564b/attachment.bin>


More information about the llvm-commits mailing list