[PATCH] D109213: [RegAllocFast] Clean-up. Remove redundant operations. NFC.

Wed Sep 28 14:58:05 PDT 2022

MatzeB added inline comments.

================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1314
       bool displacedAny = usePhysReg(MI, Reg);
-      if (!displacedAny && !MRI->isReserved(Reg))
+      if (!displacedAny)
         MO.setIsKill(true);
----------------
MatzeB wrote:
> arsenm wrote:
> > This part LGTM
> We don't track liveness for reserved register (they're considered to be always alive). So I don't see what the point of adding a kill flag here is. I would expect it to not matter one way or another and not having a kill flag being less noise...
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/CodeGen/TargetRegisterInfo.h#L520  for a comment on reserved regs.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109213/new/

https://reviews.llvm.org/D109213