[PATCH] D109213: [RegAllocFast] Clean-up. Remove redundant operations. NFC.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 15:00:51 PDT 2022


MatzeB added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1169
       if (NeedToAssignLiveThroughs) {
-        DefOperandIndexes.clear();
+        SmallVector<uint16_t, 8> DefOperandIndexes;
         PhysRegUses.clear();
----------------
arsenm wrote:
> This now may require new reallocation for each call
I would expect more than 8 def operands to be very rare so I wouldn't really worry about reallocations... That said I also don't know why moving the SmallVector around helps anything...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109213/new/

https://reviews.llvm.org/D109213



More information about the llvm-commits mailing list