[PATCH] D109213: [RegAllocFast] Clean-up. Remove redundant operations. NFC.
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 28 14:56:07 PDT 2022
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM, though maybe re-consider the kill flag change unless you have a reason to add one...
================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:1314
bool displacedAny = usePhysReg(MI, Reg);
- if (!displacedAny && !MRI->isReserved(Reg))
+ if (!displacedAny)
MO.setIsKill(true);
----------------
arsenm wrote:
> This part LGTM
We don't track liveness for reserved register (they're considered to be always alive). So I don't see what the point of adding a kill flag here is. I would expect it to not matter one way or another and not having a kill flag being less noise...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109213/new/
https://reviews.llvm.org/D109213
More information about the llvm-commits
mailing list