[PATCH] D134140: [LLD][COFF] Set OrdinalBase to 1 for export table

Mon Sep 19 06:34:15 PDT 2022

mstorsjo added inline comments.

================
Comment at: lld/test/COFF/export-all.s:11
+# CHECK:      Name:
+# CHECK-SAME:       comdatFunc
 # CHECK-NEXT: Name: dataSym
----------------
alvinhochun wrote:
> mstorsjo wrote:
> > Shouldn't this just be changed into a plain `# CHECK: Name: comdatFunc`?
> I thought we can use this CHECK and CHECK-SAME combo to make sure that the first symbol will be the expected `comdatFunc` instead of an empty entry. Though other tests has already covered this case, so your suggestion is fine too. Feel free to change it when committing, thanks.
Oh, right, that's a neat way of enforcing that - although AFAIK an uncommon idiom for writing tests. No strong opinion on it anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134140/new/

https://reviews.llvm.org/D134140