[PATCH] D134140: [LLD][COFF] Set OrdinalBase to 1 for export table
Alvin Wong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 05:38:17 PDT 2022
alvinhochun added inline comments.
================
Comment at: lld/test/COFF/export-all.s:11
+# CHECK: Name:
+# CHECK-SAME: comdatFunc
# CHECK-NEXT: Name: dataSym
----------------
mstorsjo wrote:
> Shouldn't this just be changed into a plain `# CHECK: Name: comdatFunc`?
I thought we can use this CHECK and CHECK-SAME combo to make sure that the first symbol will be the expected `comdatFunc` instead of an empty entry. Though other tests has already covered this case, so your suggestion is fine too. Feel free to change it when committing, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134140/new/
https://reviews.llvm.org/D134140
More information about the llvm-commits
mailing list