[PATCH] D133584: [DAGCombiner] [AMDGPU] Allow vector loads in MatchLoadCombine

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7982
+
+    unsigned BPVectorIndex = *VectorIndex ? 0 : *VectorIndex;
+    return ByteProvider::getMemory(L, Index, BPVectorIndex);
----------------
Is is normal that the conditions is checking if `VectorIndex` is `0` ? Shouldn't it be `auto BPVectorIndex = VectorIndex.value_or(0U);` ?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8303
   unsigned ZeroExtendedBytes = 0;
+  DenseMap<SDNode *, SmallVector<unsigned, 8>> BaseLoadIndices;
   for (int i = ByteWidth - 1; i >= 0; --i) {
----------------
This variable seems unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133584/new/

https://reviews.llvm.org/D133584