[PATCH] D134140: [LLD][COFF] Set OrdinalBase to 1 for export table

Mon Sep 19 01:32:34 PDT 2022

mstorsjo added a comment.

Looks great to me, thanks! I've wondered about this difference to other tools (although I haven't used link.exe that much that I'd have noticed the difference there too), but never enough to dig into it.

I didn't review how the other tools does it - I trust your judgement that link.exe also does it like this, where I trust link.exe much more as reference than ld.bfd.

Leaving open if @rnk wants to have a look too, otherwise I'd be happy to approve this in a couple days.

================
Comment at: lld/test/COFF/export-all.s:11
+# CHECK:      Name:
+# CHECK-SAME:       comdatFunc
 # CHECK-NEXT: Name: dataSym
----------------
Shouldn't this just be changed into a plain `# CHECK: Name: comdatFunc`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134140/new/

https://reviews.llvm.org/D134140