[PATCH] D133669: [compiler-rt] Fix wrong output path of external project target in MSVC.

[Sunho Kim via Phabricator via llvm-commits]

sunho added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:66
 
-  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
-  # AIX should fold 32-bit & 64-bit arch libraries into a single archive.
----------------
MaskRay wrote:
> mstorsjo wrote:
> > This change will change how runtime libraries are built for a lot of platforms! You can’t sneak a change like this into a patch that is just labeled to change compiler-rt! Cc @MaskRay @phosek
> https://discourse.llvm.org/t/rfc-time-to-drop-legacy-runtime-paths/64628/18 @daltenty 
Oh I was not correctly understanding the complexity here. I can drop this change in the mean time -- ORC is totally fine to use the new per-targrt directory even in MSVC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133669/new/

https://reviews.llvm.org/D133669