[PATCH] D133669: [compiler-rt] Fix wrong output path of external project target in MSVC.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 22:08:41 PDT 2022


MaskRay added a subscriber: daltenty.
MaskRay added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:66
 
-  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
-  # AIX should fold 32-bit & 64-bit arch libraries into a single archive.
----------------
mstorsjo wrote:
> This change will change how runtime libraries are built for a lot of platforms! You can’t sneak a change like this into a patch that is just labeled to change compiler-rt! Cc @MaskRay @phosek
https://discourse.llvm.org/t/rfc-time-to-drop-legacy-runtime-paths/64628/18 @daltenty 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133669/new/

https://reviews.llvm.org/D133669



More information about the llvm-commits mailing list