[PATCH] D133669: [compiler-rt] Fix wrong output path of external project target in MSVC.

Mon Sep 12 23:39:14 PDT 2022

phosek added inline comments.

================
Comment at: compiler-rt/cmake/base-config-ix.cmake:156

-if(WIN32 AND NOT MINGW AND NOT CYGWIN)
+if(MSVC)
   set(CMAKE_SHARED_LIBRARY_PREFIX_C "")
----------------
mstorsjo wrote:
> This change on its own is probably ok.
I'm a bit surprised that this is even needed, according to CMake documentation, this should already be the default: https://cmake.org/cmake/help/v3.14/variable/CMAKE_STATIC_LIBRARY_SUFFIX.html

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133669/new/

https://reviews.llvm.org/D133669