[PATCH] D133669: [compiler-rt] Fix wrong output path of external project target in MSVC.

Mon Sep 12 21:19:14 PDT 2022

mstorsjo added subscribers: MaskRay, phosek.
mstorsjo added inline comments.

================
Comment at: compiler-rt/cmake/base-config-ix.cmake:156

-if(WIN32 AND NOT MINGW AND NOT CYGWIN)
+if(MSVC)
   set(CMAKE_SHARED_LIBRARY_PREFIX_C "")
----------------
This change on its own is probably ok.

================
Comment at: llvm/runtimes/CMakeLists.txt:66

-  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
-  # AIX should fold 32-bit & 64-bit arch libraries into a single archive.
----------------
This change will change how runtime libraries are built for a lot of platforms! You can’t sneak a change like this into a patch that is just labeled to change compiler-rt! Cc @MaskRay @phosek

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133669/new/

https://reviews.llvm.org/D133669